On Oct 12, 2017, at 10:16, Gustavo A. R. Silva <garsi...@embeddedor.com> wrote:
> 
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com>

This isn't strictly necessary, since LASSERT() never returns, but
not harmful either.

Reviewed-by: Andreas Dilger <andreas.dil...@intel.com>

> ---
> drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c 
> b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
> index d0ee58d..7b014ca 100644
> --- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
> +++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
> @@ -2308,7 +2308,7 @@ ksocknal_base_shutdown(void)
>       switch (ksocknal_data.ksnd_init) {
>       default:
>               LASSERT(0);
> -
> +             /* fall through */
>       case SOCKNAL_INIT_ALL:
>       case SOCKNAL_INIT_DATA:
>               LASSERT(ksocknal_data.ksnd_peers);
> -- 
> 2.7.4
> 

Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation







_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to