Gustavo A. R. Silva, on ven. 10 nov. 2017 16:13:03 -0600, wrote: > Make use of the swap macro instead of _manually_ swapping values > and remove unnecessary variable tmp. > > This makes the code easier to read and maintain. > > This code was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com>
Acked-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > drivers/staging/speakup/selection.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/speakup/selection.c > b/drivers/staging/speakup/selection.c > index 66061b5..0ed1fef 100644 > --- a/drivers/staging/speakup/selection.c > +++ b/drivers/staging/speakup/selection.c > @@ -64,13 +64,8 @@ int speakup_set_selection(struct tty_struct *tty) > ps = spk_ys * vc->vc_size_row + (spk_xs << 1); > pe = spk_ye * vc->vc_size_row + (spk_xe << 1); > > - if (ps > pe) { > - /* make sel_start <= sel_end */ > - int tmp = ps; > - > - ps = pe; > - pe = tmp; > - } > + if (ps > pe) /* make sel_start <= sel_end */ > + swap(ps, pe); > > if (spk_sel_cons != vc_cons[fg_console].d) { > speakup_clear_selection(); > -- > 2.7.4 > -- Samuel <b> il faut combien de chevaux pour tirer une doloréan à 88 morph ? ***b vient de remarque que 88 mph c'est 142 km/h <y> aaaaah <y> c'est pour ça qu'ils limitent à 130 km/h sur les autoroutes <y> c'est pour éviter que les gens voyagent dans le temps <b> probablement _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel