On Wed, Dec 20, 2017 at 09:32:06AM +0200, Gilad Ben-Yossef wrote:
> Hi,
> 
> I've missed this patch as I wasn't CCed and just noticed it in staging-next...
> 
> On Sat, Dec 16, 2017 at 1:43 AM, Kamal Heib <kamalhe...@gmail.com> wrote:
> > This patch adds a blank line after declarations to
> > improve code readability.
> >
> > Issue find by checkpatch.pl script.
> > WARNING: Missing a blank line after declarations
> >
> 
> Thank you Kamal for the patch but in this specific case it is
> checkpatch that is wrong.
> 
> SHASH_DESC_ON_STACK macro is a definition and should not have a space
> before it, just like LIST_HEAD macro. The problem is that checkpatch is 
> missing
> correct handling of crypto API definition macros so it complains.

Ugh, sorry about that, I didn't know it.

> I've sent a patch to fix this awhile back but alas it was not picked up:
> 
> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1431518.html

Resend patches that get ignored :)

thanks,

greg k-h
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to