On Wed, Mar 21, 2018 at 03:17:51PM +0300, Denis Kirjanov wrote:
> On 3/21/18, David Laight <david.lai...@aculab.com> wrote:
> > From: > hariprasath.ela...@gmail.com
> >> Sent: 21 March 2018 11:16
> >> From: HariPrasath Elango <hariprasath.ela...@gmail.com>
> >>
> >> Replace a couple of simple switch cases by if condition
> >
> > Why?
> > In principle extra 'case' might be needed in the future.
>
> I had the same question when saw it.
> It's better to keep things as is.
> >
> > ...
Hi, since the switch statement had only one case,I thought of doing
this. If there are plans to add more cases, we can leave it like
that.
thanks,
hari
> >> diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c
> >> b/drivers/staging/fsl-
> >> dpaa2/ethernet/dpaa2-ethtool.c
> >> index 070a3f2..fb517cb 100644
> >> --- a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c
> >> +++ b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c
> >> @@ -171,8 +171,7 @@ static void dpaa2_eth_get_strings(struct net_device
> >> *netdev, u32 stringset,
> >> u8 *p = data;
> >> int i;
> >>
> >> - switch (stringset) {
> >> - case ETH_SS_STATS:
> >> + if (stringset == ETH_SS_STATS) {
> >> for (i = 0; i < DPAA2_ETH_NUM_STATS; i++) {
> >> strlcpy(p, dpaa2_ethtool_stats[i], ETH_GSTRING_LEN);
> >> p += ETH_GSTRING_LEN;
> >> @@ -181,18 +180,16 @@ static void dpaa2_eth_get_strings(struct net_device
> >> *netdev, u32 stringset,
> >> strlcpy(p, dpaa2_ethtool_extras[i], ETH_GSTRING_LEN);
> >> p += ETH_GSTRING_LEN;
> >> }
> >> - break;
> >> }
> >> }
> > ...
> >
> > David
> >
> > _______________________________________________
> > devel mailing list
> > de...@linuxdriverproject.org
> > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> >
>
>
> --
> Regards / Mit besten Grüßen,
> Denis
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
