> if (unlikely(par->debug & DEBUG_WRITE_REGISTER)) { \
> va_start(args, len); \
> for (i = 0; i < len; i++) { \
> - buf[i] = modifier((data_type)va_arg(args, unsigned
> int)); \
> + buf[i] = modifier((data_type)va_arg(args, \
> + unsigned int)); \
Normally we'd align the parameters like so:
buf[i] = modifier((data_type)va_arg(args,
\
unsigned int));
\
> } \
> va_end(args); \
> - fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par, par->info->device,
> buffer_type, buf, len, "%s: ", __func__); \
> + fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par, \
> + par->info->device, buffer_type, \
> + buf, len, "%s: ", __func__); \
> } \
Not properly aligned.
> \
> va_start(args, len); \
> @@ -37,7 +40,8 @@ void func(struct fbtft_par *par, int len, ...)
> \
> } \
> \
> *buf = modifier((data_type)va_arg(args, unsigned int)); \
> - ret = fbtft_write_buf_dc(par, par->buf, sizeof(data_type) + offset, 0);
> \
I feel like the original is basically OK but if we're going to change it
then align it like this:
ret = fbtft_write_buf_dc(par, par->buf, sizeof(data_type) + offset,
\
0);
\
Etc.
regards,
dan carpenter
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
