On Fri, Jun 08, 2018 at 12:33:56AM -0400, Janani Sankara Babu wrote: > This patch removes comparison to False(ie. bool) in the code > > Signed-off-by: Janani Sankara Babu <janani...@gmail.com> > --- > drivers/staging/rtl8192e/rtl819x_BAProc.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c > b/drivers/staging/rtl8192e/rtl819x_BAProc.c > index 3c7ba33..ccd898a 100644 > --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c > +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c > @@ -258,7 +258,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct > sk_buff *skb) > > RT_TRACE(COMP_DBG, "====>rx ADDBAREQ from : %pM\n", dst); > if (ieee->current_network.qos_data.active == 0 ||
Is .active the number of active or is it a boolean? If it's boolean then it should be changed to !ieee->current_network.qos_data.active as well. Keep your eyes open for stuff like this when you're doing checkpatch fixes. > - (ieee->pHTInfo->bCurrentHTSupport == false) || > + !(ieee->pHTInfo->bCurrentHTSupport) || Remove the parenthesis. Same throughout. regards, dan carpenter _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
