On Wed, Jun 06, 2018 at 12:40:03PM +0100, John Whitmore wrote:
> @@ -1072,10 +1072,10 @@ void HTInitializeHTInfo(struct ieee80211_device *ieee)
> pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor;
>
> // Initialize all of the parameters related to 11n
> - memset((void *)(&(pHTInfo->SelfHTCap)), 0, sizeof(pHTInfo->SelfHTCap));
> - memset((void *)(&(pHTInfo->SelfHTInfo)), 0,
> sizeof(pHTInfo->SelfHTInfo));
> - memset((void *)(&(pHTInfo->PeerHTCapBuf)), 0,
> sizeof(pHTInfo->PeerHTCapBuf));
> - memset((void *)(&(pHTInfo->PeerHTInfoBuf)), 0,
> sizeof(pHTInfo->PeerHTInfoBuf));
> + memset((void *)(&pHTInfo->SelfHTCap), 0, sizeof(pHTInfo->SelfHTCap));
> + memset((void *)(&pHTInfo->SelfHTInfo), 0, sizeof(pHTInfo->SelfHTInfo));
> + memset((void *)(&pHTInfo->PeerHTCapBuf), 0,
> sizeof(pHTInfo->PeerHTCapBuf));
> + memset((void *)(&pHTInfo->PeerHTInfoBuf), 0,
> sizeof(pHTInfo->PeerHTInfoBuf));
You should write these like so:
memset(&pHTInfo->PeerHTInfoBuf, 0, sizeof(pHTInfo->PeerHTInfoBuf));
The first 7 patches look fine, but can you resend this last one?
regards,
dan carpenter
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
