Re: [PATCH 3/6] staging: rtl8723bs: fix indentation

[Michael Straube]

On 07/08/18 18:46, Joe Perches wrote:

On Sun, 2018-07-08 at 12:38 +0200, Michael Straube wrote:

Remove unrequired extra indentations.

[]

diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c 
b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c

[]

@@ -69,16 +69,16 @@ int rtw_get_bit_value_from_ieee_value(u8 val)

uint rtw_is_cckrates_included(u8 *rate)

  {
-               u32 i = 0;
+       u32 i = 0;

- while (rate[i] != 0) {

-                       if  ((((rate[i]) & 0x7f) == 2)      || (((rate[i]) & 
0x7f) == 4) ||
-                            (((rate[i]) & 0x7f) == 11)  || (((rate[i]) & 0x7f) 
== 22))
-                               return true;
-                       i++;
-               }
+       while (rate[i] !=  0) {
+               if  ((((rate[i]) & 0x7f) == 2)      || (((rate[i]) & 0x7f) == 
4) ||
+                    (((rate[i]) & 0x7f) == 11)  || (((rate[i]) & 0x7f) == 22))
+                       return true;
+               i++;
+       }

- return false;

+       return false;
  }

Hi Michael.

Please try to improve the code for human readers and/or
reduce overall object size over merely shutting up checkpatch
style warnings.

Hi Joe,

I agree that it's better to improve the code than just silence
warnings.

Thanks for your advice.

For instance:

You could reduce object size a little by eliminating the
multiple use of 0x7f and index and dereferencing the
pointer instead.

$ size drivers/staging/rtl8723bs/core/rtw_ieee80211.o*
    text           data     bss     dec     hex filename
   10085             76       0   10161    27b1 
drivers/staging/rtl8723bs/core/rtw_ieee80211.o.new
   10149             76       0   10225    27f1 
drivers/staging/rtl8723bs/core/rtw_ieee80211.o.old

Something like:

uint rtw_is_cckrates_included(u8 *rate)
{
        while (*rate) {
                u8 r = *rate & 0x7f;

                if (r == 2 || r == 4 || r == 11 || r == 22)
                        return true;
                rate++;
        }

        return false;
}

uint rtw_is_cckratesonly_included(u8 *rate)
{
        while (*rate) {
                u8 r = *rate & 0x7f;

                if (r != 2 && r != 4 && r != 11 && r != 22)
                        return false;
                rate++;
        }

        return true;
}

The patch has been added to staging-testing already.
I will send patches with your suggestions the next days.

Thanks again.

Michael
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel