From: Todd Poynor <toddpoy...@google.com>

Use container_of(), drop unnecessary NULL check.

Reported-by: Dmitry Torokhov <d...@chromium.org>
Signed-off-by: Zhongze Hu <fran...@chromium.org>
Signed-off-by: Todd Poynor <toddpoy...@google.com>
---
 drivers/staging/gasket/gasket_core.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/gasket/gasket_core.c 
b/drivers/staging/gasket/gasket_core.c
index ffd6ce801313..0c45c54254fb 100644
--- a/drivers/staging/gasket/gasket_core.c
+++ b/drivers/staging/gasket/gasket_core.c
@@ -1099,12 +1099,9 @@ static int gasket_open(struct inode *inode, struct file 
*filp)
        const struct gasket_driver_desc *driver_desc;
        struct gasket_ownership *ownership;
        char task_name[TASK_COMM_LEN];
-       struct gasket_cdev_info *dev_info = gasket_cdev_get_info(inode->i_cdev);
+       struct gasket_cdev_info *dev_info =
+           container_of(inode->i_cdev, struct gasket_cdev_info, cdev);
 
-       if (!dev_info) {
-               gasket_nodev_error("Unable to retrieve device data");
-               return -EINVAL;
-       }
        gasket_dev = dev_info->gasket_dev_ptr;
        driver_desc = gasket_dev->internal_desc->driver_desc;
        ownership = &dev_info->ownership;
-- 
2.18.0.203.gfac676dfb9-goog

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to