Re: [PATCH 1/2] staging: erofs: add the missing break in z_erofs_map_blocks_iter

[Dan Carpenter]

On Wed, Aug 01, 2018 at 02:38:30PM +0800, Gao Xiang wrote:
> diff --git a/drivers/staging/erofs/unzip_vle.c 
> b/drivers/staging/erofs/unzip_vle.c
> index bd2d7a8..6d3ab31 100644
> --- a/drivers/staging/erofs/unzip_vle.c
> +++ b/drivers/staging/erofs/unzip_vle.c
> @@ -1596,10 +1596,10 @@ int z_erofs_map_blocks_iter(struct inode *inode,
>       cluster_type = vle_cluster_type(di);
>  
>       switch (cluster_type) {
> -     case Z_EROFS_VLE_CLUSTER_TYPE_PLAIN:
> +     case Z_EROFS_VLE_CLUSTER_TYPE_PLAIN:    /* fallthrough */

This fallthrough comment is in the wrong place.  It should be at the end
where the break would have been.  Like this:

        switch (cluster_type) {
        case Z_EROFS_VLE_CLUSTER_TYPE_PLAIN:
                frob();
                frob();
                frob();
                /* fallthrough */
        case Z_EROFS_VLE_CLUSTER_TYPE_HEAD:
                frob();

regards,
dan carpenter

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel