There are some printk's which can be replaced properly
using dev_* kernel functions. Use dev_info to show
N_FTS status for each port using a loop instead of duplicating
lines of code.

Signed-off-by: Sergio Paracuellos <sergio.paracuel...@gmail.com>
---
 drivers/staging/mt7621-pci/pci-mt7621.c | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c 
b/drivers/staging/mt7621-pci/pci-mt7621.c
index ec1d822..f499c108 100644
--- a/drivers/staging/mt7621-pci/pci-mt7621.c
+++ b/drivers/staging/mt7621-pci/pci-mt7621.c
@@ -568,14 +568,11 @@ static int mt7621_pci_probe(struct platform_device *pdev)
                bypass_pipe_rst(pcie);
        set_phy_for_ssc(pcie);
 
-       val = read_config(pcie, 0, 0x70c);
-       printk("Port 0 N_FTS = %x\n", (unsigned int)val);
-
-       val = read_config(pcie, 1, 0x70c);
-       printk("Port 1 N_FTS = %x\n", (unsigned int)val);
-
-       val = read_config(pcie, 2, 0x70c);
-       printk("Port 2 N_FTS = %x\n", (unsigned int)val);
+       list_for_each_entry_safe(port, tmp, &pcie->ports, list) {
+               u32 slot = port->slot;
+               val = read_config(pcie, slot, 0x70c);
+               dev_info(dev, "Port %d N_FTS = %x\n", (unsigned int)val, slot);
+       }
 
        rt_sysc_m32(0, RALINK_PCIE_RST, RALINK_RSTCTRL);
        rt_sysc_m32(0x30, 2 << 4, SYSC_REG_SYSTEM_CONFIG1);
-- 
2.7.4

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to