On 9/5/18 10:13 AM, Dan Carpenter wrote:
On Tue, Sep 04, 2018 at 01:16:15PM +0200, Michael Straube wrote:

        case LED_CTL_SITE_SURVEY:
-               if ((pmlmepriv->LinkDetectInfo.bBusyTraffic) && 
(check_fwstate(pmlmepriv, _FW_LINKED))) {
-                       ;
-               } else if (!pLed->bLedScanBlinkInProgress) {
+               if (!pLed->bLedScanBlinkInProgress) {

I think you have introduced a bug...

Ah yes I see now, thanks.
Would it be ok to merge the conditions in a single if?

if ((!pmlmepriv->LinkDetectInfo.bBusyTraffic ||
    !check_fwstate(pmlmepriv, _FW_LINKED)) &&
    !pLed->bLedScanBlinkInProgress) {


regards,
Michael
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to