linux-ker...@vger.kernel.org Cc: Bcc: Subject: [PATCH] staging/rtlwifi: Fixing formatting warnings from checkpatch.pl. Reply-To:
On Fri, 10/5/18 at 6:37PM Joe Perches wrote: >On Fri, 2018-10-05 at 16:58 -0600, Scott Tracy wrote: >> Fixing formatting warnings in rtlwifi found by checkpatch.pl >> Changes include breaking up functions calls into multi line calls. >> No functional/logical changes. > >I believe the code is better before most of these changes. > >There are various tradeoffs do source code formatting. > >Here you are changing some alignment to open parentheses >and converting to < 80 columns. Fair critisim. I was learning from the tutorial on kernelnewbies.org, and picked simple warnings to correct. The initial thought was that a "check" was better than a "warning". I just hesitated to jumping into refactoring the code to get it under the 80 column limit. I will look for a better target to change. Thanks, Scott Tracy _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
