Hi Andrew, Sorry for late. Just come back from holiday.
Hi Ioana, Could you generate an additional patch for dpaa2_eth to address Andrew's comments? There was also a warning when checked patch. FSL_DPAA2_ETH needed more description. WARNING: please write a paragraph that describes the config symbol fully #66: FILE: drivers/net/ethernet/freescale/dpaa2/Kconfig:1: +config FSL_DPAA2_ETH Thanks a lot. Best regards, Yangbo Lu > -----Original Message----- > From: Andrew Lunn <and...@lunn.ch> > Sent: Sunday, September 30, 2018 3:46 AM > To: Y.b. Lu <yangbo...@nxp.com> > Cc: linux-ker...@vger.kernel.org; de...@driverdev.osuosl.org; > net...@vger.kernel.org; Richard Cochran <richardcoch...@gmail.com>; > David S . Miller <da...@davemloft.net>; Ioana Ciocoi Radulescu > <ruxandra.radule...@nxp.com>; Greg Kroah-Hartman > <gre...@linuxfoundation.org> > Subject: Re: [v2, 1/5] net: dpaa2: move DPAA2 PTP driver out of staging/ > > > +++ b/drivers/net/ethernet/freescale/dpaa2/Kconfig > > @@ -0,0 +1,15 @@ > > +config FSL_DPAA2_ETH > > + tristate "Freescale DPAA2 Ethernet" > > + depends on FSL_MC_BUS && FSL_MC_DPIO > > Could you add in here COMPILE_TEST? > > > + depends on NETDEVICES && ETHERNET > > With the move out of staging, i don't think these two are required. > > Andrew _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
