On Thu, Jan 24, 2019 at 02:12:13PM +0100, Vitaly Kuznetsov wrote:
> Maya Nakamura <m.maya.nakam...@gmail.com> writes:
> 
> > @@ -460,12 +454,16 @@ struct hv_pcibus_device {
> >     struct msi_controller msi_chip;
> >     struct irq_domain *irq_domain;
> >  
> > -   /* hypercall arg, must not cross page boundary */
> > -   struct retarget_msi_interrupt retarget_msi_interrupt_params;
> > -
> >     spinlock_t retarget_msi_interrupt_lock;
> >  
> >     struct workqueue_struct *wq;
> > +
> > +   /* hypercall arg, must not cross page boundary */
> > +   struct retarget_msi_interrupt retarget_msi_interrupt_params;
> > +
> > +   /*
> > +    * Don't put anything here: retarget_msi_interrupt_params must be last
> > +    */
> 
> This change seems to be unrelated and not anyhow described in the commit
> message - or did I miss something?
> 
Thank you for pointing that out. I will add why it was moved in v2.

Maya
> 
> -- 
> Vitaly
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to