Hi Florian, I love your patch! Yet something to improve:
[auto build test ERROR on net/master] [also build test ERROR on next-20190205] [cannot apply to v5.0-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-Introduce-ndo_get_port_parent_id/20190205-163356 config: i386-randconfig-x008-201905 (attached as .config) compiler: gcc-8 (Debian 8.2.0-14) 8.2.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/net/netdevsim/netdev.c:485:3: error: 'const struct net_device_ops' has no member named 'ndo_get_port_paret_id'; did you mean 'ndo_get_port_parent_id'? .ndo_get_port_paret_id = nsim_get_port_parent_id, ^~~~~~~~~~~~~~~~~~~~~ ndo_get_port_parent_id >> drivers/net/netdevsim/netdev.c:485:27: error: positional initialization of >> field in 'struct' declared with 'designated_init' attribute >> [-Werror=designated-init] .ndo_get_port_paret_id = nsim_get_port_parent_id, ^~~~~~~~~~~~~~~~~~~~~~~ drivers/net/netdevsim/netdev.c:485:27: note: (near initialization for 'nsim_netdev_ops') drivers/net/netdevsim/netdev.c:485:27: error: initialization of 'void (*)(struct net_device *, struct udp_tunnel_info *)' from incompatible pointer type 'int (*)(struct net_device *, struct netdev_phys_item_id *)' [-Werror=incompatible-pointer-types] drivers/net/netdevsim/netdev.c:485:27: note: (near initialization for 'nsim_netdev_ops.ndo_udp_tunnel_add') cc1: some warnings being treated as errors vim +485 drivers/net/netdevsim/netdev.c 464 465 static const struct net_device_ops nsim_netdev_ops = { 466 .ndo_init = nsim_init, 467 .ndo_uninit = nsim_uninit, 468 .ndo_start_xmit = nsim_start_xmit, 469 .ndo_set_rx_mode = nsim_set_rx_mode, 470 .ndo_set_mac_address = eth_mac_addr, 471 .ndo_validate_addr = eth_validate_addr, 472 .ndo_change_mtu = nsim_change_mtu, 473 .ndo_get_stats64 = nsim_get_stats64, 474 .ndo_set_vf_mac = nsim_set_vf_mac, 475 .ndo_set_vf_vlan = nsim_set_vf_vlan, 476 .ndo_set_vf_rate = nsim_set_vf_rate, 477 .ndo_set_vf_spoofchk = nsim_set_vf_spoofchk, 478 .ndo_set_vf_trust = nsim_set_vf_trust, 479 .ndo_get_vf_config = nsim_get_vf_config, 480 .ndo_set_vf_link_state = nsim_set_vf_link_state, 481 .ndo_set_vf_rss_query_en = nsim_set_vf_rss_query_en, 482 .ndo_setup_tc = nsim_setup_tc, 483 .ndo_set_features = nsim_set_features, 484 .ndo_bpf = nsim_bpf, > 485 .ndo_get_port_paret_id = nsim_get_port_parent_id, 486 }; 487 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
_______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
