Hi Greg, I love your patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing] [also build test WARNING on next-20190418] [cannot apply to v5.1-rc5] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Greg-Kroah-Hartman/staging-kpc2000-add-initial-set-of-Daktronics-drivers/20190420-142353 config: mips-allmodconfig (attached as .config) compiler: mips-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=mips If you fix the issue, kindly add following tag Reported-by: kbuild test robot <l...@intel.com> All warnings (new ones prefixed by >>): drivers/staging/kpc2000/kpc2000/fileops.c: In function 'kp2000_cdev_read': >> drivers/staging/kpc2000/kpc2000/fileops.c:74:1: warning: the frame size of >> 1064 bytes is larger than 1024 bytes [-Wframe-larger-than=] } ^ -- In file included from include/linux/pci.h:31:0, from drivers/staging/kpc2000/kpc2000/core.c:4: drivers/staging/kpc2000/kpc2000/core.c: In function 'read_system_regs': >> drivers/staging/kpc2000/kpc2000/core.c:148:36: warning: format '%lx' expects >> argument of type 'long unsigned int', but argument 4 has type 'long long >> int' [-Wformat=] dev_err(&pcard->pdev->dev, "Invalid magic! Got: 0x%016llx Want: 0x%016lx\n", read_val, KP2000_MAGIC_VALUE); ^ include/linux/device.h:1400:22: note: in definition of macro 'dev_fmt' #define dev_fmt(fmt) fmt ^~~ drivers/staging/kpc2000/kpc2000/core.c:148:9: note: in expansion of macro 'dev_err' dev_err(&pcard->pdev->dev, "Invalid magic! Got: 0x%016llx Want: 0x%016lx\n", read_val, KP2000_MAGIC_VALUE); ^~~~~~~ vim +74 drivers/staging/kpc2000/kpc2000/fileops.c 36 37 38 ssize_t kp2000_cdev_read(struct file *filp, char __user *buf, size_t count, loff_t *f_pos) 39 { 40 struct kp2000_device *pcard = filp->private_data; 41 int cnt = 0; 42 int ret; 43 #define BUFF_CNT 1024 44 char buff[BUFF_CNT] = {0}; //NOTE: Increase this so it is at least as large as all the scnprintfs. And don't use unbounded strings. "%s" 45 //NOTE: also, this is a really shitty way to implement the read() call, but it will work for any size 'count'. 46 47 if (WARN(NULL == buf, "kp2000_cdev_read: buf is a NULL pointer!\n")) 48 return -EINVAL; 49 50 cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "Card ID : 0x%08x\n", pcard->card_id); 51 cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "Build Version : 0x%08x\n", pcard->build_version); 52 cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "Build Date : 0x%08x\n", pcard->build_datestamp); 53 cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "Build Time : 0x%08x\n", pcard->build_timestamp); 54 cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "Core Table Offset : 0x%08x\n", pcard->core_table_offset); 55 cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "Core Table Length : 0x%08x\n", pcard->core_table_length); 56 cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "Hardware Revision : 0x%08x\n", pcard->hardware_revision); 57 cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "SSID : 0x%016llx\n", pcard->ssid); 58 cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "DDNA : 0x%016llx\n", pcard->ddna); 59 cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "IRQ Mask : 0x%016llx\n", readq(pcard->sysinfo_regs_base + REG_INTERRUPT_MASK)); 60 cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "IRQ Active : 0x%016llx\n", readq(pcard->sysinfo_regs_base + REG_INTERRUPT_ACTIVE)); 61 cnt += scnprintf(buff+cnt, BUFF_CNT-cnt, "CPLD : 0x%016llx\n", readq(pcard->sysinfo_regs_base + REG_CPLD_CONFIG)); 62 63 if (*f_pos >= cnt) 64 return 0; 65 66 if (count > cnt) 67 count = cnt; 68 69 ret = copy_to_user(buf, buff + *f_pos, count); 70 if (ret) 71 return -EFAULT; 72 *f_pos += count; 73 return count; > 74 } 75 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
_______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
