> -----Original Message----- > From: Geert Uytterhoeven <ge...@linux-m68k.org> > Sent: Monday, 13 May 2019 5:01 PM > To: Alastair D'Silva <alast...@au1.ibm.com> > Cc: alast...@d-silva.org; Jani Nikula <jani.nik...@linux.intel.com>; Joonas > Lahtinen <joonas.lahti...@linux.intel.com>; Rodrigo Vivi > <rodrigo.v...@intel.com>; David Airlie <airl...@linux.ie>; Daniel Vetter > <dan...@ffwll.ch>; Dan Carpenter <dan.carpen...@oracle.com>; Karsten > Keil <i...@linux-pingi.de>; Jassi Brar <jassisinghb...@gmail.com>; Tom > Lendacky <thomas.lenda...@amd.com>; David S. Miller > <da...@davemloft.net>; Jose Abreu <jose.ab...@synopsys.com>; Kalle > Valo <kv...@codeaurora.org>; Stanislaw Gruszka <sgrus...@redhat.com>; > Benson Leung <ble...@chromium.org>; Enric Balletbo i Serra > <enric.balle...@collabora.com>; James E.J. Bottomley > <j...@linux.ibm.com>; Martin K. Petersen <martin.peter...@oracle.com>; > Greg Kroah-Hartman <gre...@linuxfoundation.org>; Alexander Viro > <v...@zeniv.linux.org.uk>; Petr Mladek <pmla...@suse.com>; Sergey > Senozhatsky <sergey.senozhat...@gmail.com>; Steven Rostedt > <rost...@goodmis.org>; David Laight <david.lai...@aculab.com>; Andrew > Morton <a...@linux-foundation.org>; Intel Graphics Development <intel- > g...@lists.freedesktop.org>; DRI Development <dri- > de...@lists.freedesktop.org>; Linux Kernel Mailing List <linux- > ker...@vger.kernel.org>; netdev <net...@vger.kernel.org>; > ath...@lists.infradead.org; linux-wireless <linux-wirel...@vger.kernel.org>; > scsi <linux-s...@vger.kernel.org>; Linux Fbdev development list <linux- > fb...@vger.kernel.org>; driverdevel <de...@driverdev.osuosl.org>; Linux > FS Devel <linux-fsde...@vger.kernel.org> > Subject: Re: [PATCH v2 3/7] lib/hexdump.c: Optionally suppress lines of > repeated bytes > > Hi Alastair, > > Thanks for your patch!
And thanks for your politeness :) > > On Wed, May 8, 2019 at 9:04 AM Alastair D'Silva <alast...@au1.ibm.com> > wrote: > > From: Alastair D'Silva <alast...@d-silva.org> > > > > Some buffers may only be partially filled with useful data, while the > > rest is padded (typically with 0x00 or 0xff). > > > > This patch introduces a flag to allow the supression of lines of > > repeated bytes, > > Given print_hex_dump() operates on entities of groupsize (1, 2, 4, or 8) > bytes, wouldn't it make more sense to consider repeated groups instead of > repeated bytes? Maybe, it would mean that subsequent addresses may not be a multiple of rowsize though, which is useful. > > which are replaced with '** Skipped %u bytes of value 0x%x **' > > Using a custom message instead of just "*", like "hexdump" uses, will require > preprocessing the output when recovering the original binary data by > feeding it to e.g. "xxd". > This may sound worse than it is, though, as I never got "xxd" to work without > preprocessing anyway ;-) I think showing the details of the skipped values is useful when reading the output directly. In situations where binary extracts are desired, the feature can always be disabled. -- Alastair D'Silva mob: 0423 762 819 skype: alastair_dsilva msn: alast...@d-silva.org blog: http://alastair.d-silva.org Twitter: @EvilDeece _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
