On Wed, Oct 16, 2019 at 05:59:50PM +0300, Dan Carpenter wrote:
> On Wed, Oct 16, 2019 at 07:37:53PM +0530, Aliasgar Surti wrote:
> > --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> > +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> > @@ -507,19 +507,9 @@ int rtw_cmd_thread(void *context)
> >  
> >             cmd_process_time = jiffies_to_msecs(jiffies - cmd_start_time);
> >             if (cmd_process_time > 1000) {
> > -                   if (pcmd->cmdcode == GEN_CMD_CODE(_Set_Drv_Extra)) {
> > -                           DBG_871X(ADPT_FMT" cmd =%d process_time =%lu > 
> > 1 sec\n",
> > -                                   ADPT_ARG(pcmd->padapter), 
> > pcmd->cmdcode, cmd_process_time);
> > -                           /* rtw_warn_on(1); */
> > -                   } else if (pcmd->cmdcode == 
> > GEN_CMD_CODE(_Set_MLME_EVT)) {
> > -                           DBG_871X(ADPT_FMT" cmd =%d, process_time =%lu > 
> > 1 sec\n",
> > -                                   ADPT_ARG(pcmd->padapter), 
> > pcmd->cmdcode, cmd_process_time);
> > -                           /* rtw_warn_on(1); */
> > -                   } else {
> > -                           DBG_871X(ADPT_FMT" cmd =%d, process_time =%lu > 
> > 1 sec\n",
> > -                                   ADPT_ARG(pcmd->padapter), 
> > pcmd->cmdcode, cmd_process_time);
> > -                           /* rtw_warn_on(1); */
> > -                   }
> > +                   DBG_871X(ADPT_FMT "cmd= %d process_time= %lu > 1 sec\n",
> > +                            ADPT_ARG(pcmd->padapter), pcmd->cmdcode,
> > +                                     cmd_process_time);
> 
> This last line is aligned to the wrong parenthesis.  It should be:
> 
>                       DBG_871X(ADPT_FMT "cmd= %d process_time= %lu > 1 sec\n",
>                                ADPT_ARG(pcmd->padapter), pcmd->cmdcode,
>                                cmd_process_time);
My bad. I will correct this and send v2.

Thanks,
Aliasgar

> 
> regards,
> dan carpenter
> 
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to