[PATCH] staging: vchiq: Have vchiu_queue_init() return 0 on success.

[Marcelo Diop-Gonzalez]

It could be confusing to return 1 on success and 0 on error
given the style elswhere.

Signed-off-by: Marcelo Diop-Gonzalez <marcgonza...@google.com>
---
 .../staging/vc04_services/interface/vchiq_arm/vchiq_shim.c    | 2 +-
 .../staging/vc04_services/interface/vchiq_arm/vchiq_util.c    | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c 
b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
index 17a4f2c8d8b1..c76d5b2e0701 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
@@ -579,7 +579,7 @@ static struct shim_service *service_alloc(VCHIQ_INSTANCE_T 
instance,
        (void)instance;
 
        if (service) {
-               if (vchiu_queue_init(&service->queue, 64)) {
+               if (!vchiu_queue_init(&service->queue, 64)) {
                        service->callback = setup->callback;
                        service->callback_param = setup->callback_param;
                } else {
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c 
b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c
index 5e6d3035dc05..644844d88fed 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c
@@ -24,9 +24,9 @@ int vchiu_queue_init(struct vchiu_queue *queue, int size)
                                 GFP_KERNEL);
        if (!queue->storage) {
                vchiu_queue_delete(queue);
-               return 0;
+               return -ENOMEM;
        }
-       return 1;
+       return 0;
 }
 
 void vchiu_queue_delete(struct vchiu_queue *queue)
-- 
2.20.1

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel