On Wed, 2019-11-06 at 18:08 +0000, Valery Ivanov wrote:
> This patch fix the function signature for
> trace_gasket_ioctl_page_table_data
> to avoid the checkpatch.pl warning:
>
> CHECK: Lines should not end with a '('
>
> Signed-off-by: Valery Ivanov <ivalery...@gmail.com>
All of this stuff is no-op and could just as easily be removed
completely as GASKET_KERNEL_TRACE_SUPPORT is not #defined anywhere.
Is the actual trace #include file supposed to be available somewhere?
#ifdef GASKET_KERNEL_TRACE_SUPPORT
#define CREATE_TRACE_POINTS
#include <trace/events/gasket_ioctl.h>
#else
#define trace_gasket_ioctl_entry(x, ...)
#define trace_gasket_ioctl_exit(x)
#define trace_gasket_ioctl_integer_data(x)
#define trace_gasket_ioctl_eventfd_data(x, ...)
#define trace_gasket_ioctl_page_table_data(x, ...)
#define trace_gasket_ioctl_config_coherent_allocator(x, ...)
#endif
trace file not found...
> ---
> drivers/staging/gasket/gasket_ioctl.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/gasket/gasket_ioctl.c
> b/drivers/staging/gasket/gasket_ioctl.c
> index 240f9bb..55cb6b1 100644
> --- a/drivers/staging/gasket/gasket_ioctl.c
> +++ b/drivers/staging/gasket/gasket_ioctl.c
> @@ -54,9 +54,10 @@ static int gasket_read_page_table_size(struct gasket_dev
> *gasket_dev,
> ibuf.size = gasket_page_table_num_entries(
> gasket_dev->page_table[ibuf.page_table_index]);
>
> - trace_gasket_ioctl_page_table_data(
> - ibuf.page_table_index, ibuf.size, ibuf.host_address,
> - ibuf.device_address);
> + trace_gasket_ioctl_page_table_data(ibuf.page_table_index,
> + ibuf.size,
> + ibuf.host_address,
> + ibuf.device_address);
>
> if (copy_to_user(argp, &ibuf, sizeof(ibuf)))
> return -EFAULT;
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
