On March 11, 2020 10:34:28 PM GMT+05:30, Stefano Brivio
<sbri...@redhat.com> wrote:
Hey Stefano,
>On Wed, 11 Mar 2020 18:47:42 +0530
>Shreeya Patel <shreeya.patel23...@gmail.com> wrote:
>
>> Add space around operators for improving the code
>> readability.
>> Reported by checkpatch.pl
>>
>> git diff -w shows no difference.
>> diff of the .o files before and after the changes shows no
>difference.
>>
>> Signed-off-by: Shreeya Patel <shreeya.patel23...@gmail.com>
>
>This looks good to me. Further clean-ups here could probably make this
>look less messy (there are long lines, unnecessary parentheses that are
>rather confusing, especially on that 4/5 factor, "magic" constants that
>might make sense to figure out the meaning of, etc.).
>
Thanks for reviewing. I will surely look at the other clean-ups as well :)
Thanks
>Reviewed-by: Stefano Brivio <sbri...@redhat.com>
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel