On Mon, 30 Mar 2020 11:45:17 -0700 "John B. Wyatt IV" <jbwya...@gmail.com> wrote:
> Add error code handling to unused 'ret' variable that was never used. > Return an error code from functions called within vnt_radio_power_on. > > Issue reported by coccinelle (coccicheck). > > Suggested-by: Quentin Deslandes <quentin.deslan...@itdev.co.uk> > Suggested-by: Stefano Brivio <sbri...@redhat.com> > Reviewed-by: Quentin Deslandes <quentin.deslan...@itdev.co.uk> > Signed-off-by: John B. Wyatt IV <jbwya...@gmail.com> > --- > v5: Remove Suggested-by: Julia Lawall above seperator line. > Remove break; statement in switch block. > break; removal checked by both gcc compile and checkpatch. > > [...] > > @@ -734,14 +738,15 @@ int vnt_radio_power_on(struct vnt_private *priv) > case RF_VT3226: > case RF_VT3226D0: > case RF_VT3342A0: > - vnt_mac_reg_bits_on(priv, MAC_REG_SOFTPWRCTL, > - (SOFTPWRCTL_SWPE2 | SOFTPWRCTL_SWPE3)); > + ret = vnt_mac_reg_bits_on(priv, MAC_REG_SOFTPWRCTL, > + (SOFTPWRCTL_SWPE2 | > + SOFTPWRCTL_SWPE3)); > break; > } > + if (ret) > + return ret; Did you send the wrong version perhaps? -- Stefano _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
