From: Jérôme Pouiller <jerome.pouil...@silabs.com>

Currently, the ISR check if bus->core is not NULL. But, it is a useless
check. bus->core is initialiased before to request IRQ and it is not
assigned to NULL when it is released.

Signed-off-by: Jérôme Pouiller <jerome.pouil...@silabs.com>
---
 drivers/staging/wfx/bus_sdio.c | 9 +--------
 drivers/staging/wfx/bus_spi.c  | 4 ----
 2 files changed, 1 insertion(+), 12 deletions(-)

diff --git a/drivers/staging/wfx/bus_sdio.c b/drivers/staging/wfx/bus_sdio.c
index dedc3ff58d3e..9ac87178270f 100644
--- a/drivers/staging/wfx/bus_sdio.c
+++ b/drivers/staging/wfx/bus_sdio.c
@@ -91,20 +91,13 @@ static void wfx_sdio_irq_handler(struct sdio_func *func)
 {
        struct wfx_sdio_priv *bus = sdio_get_drvdata(func);
 
-       if (bus->core)
-               wfx_bh_request_rx(bus->core);
-       else
-               WARN(!bus->core, "race condition in driver init/deinit");
+       wfx_bh_request_rx(bus->core);
 }
 
 static irqreturn_t wfx_sdio_irq_handler_ext(int irq, void *priv)
 {
        struct wfx_sdio_priv *bus = priv;
 
-       if (!bus->core) {
-               WARN(!bus->core, "race condition in driver init/deinit");
-               return IRQ_NONE;
-       }
        sdio_claim_host(bus->func);
        wfx_bh_request_rx(bus->core);
        sdio_release_host(bus->func);
diff --git a/drivers/staging/wfx/bus_spi.c b/drivers/staging/wfx/bus_spi.c
index 61e99b09decb..03f95e65d2f9 100644
--- a/drivers/staging/wfx/bus_spi.c
+++ b/drivers/staging/wfx/bus_spi.c
@@ -140,10 +140,6 @@ static irqreturn_t wfx_spi_irq_handler(int irq, void *priv)
 {
        struct wfx_spi_priv *bus = priv;
 
-       if (!bus->core) {
-               WARN(!bus->core, "race condition in driver init/deinit");
-               return IRQ_NONE;
-       }
        queue_work(system_highpri_wq, &bus->request_rx);
        return IRQ_HANDLED;
 }
-- 
2.26.1

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to