On Sun, May 10, 2020 at 11:13:08AM +0100, John Oldman wrote: > Coding style issue > This patch clears the checkpatch.pl "Block comments should align the * on > each line" warning. > > Signed-off-by: John Oldman <john.old...@polehill.co.uk> > --- > v1: Initial attempt. > v2: Resubmitted with shorter comment line, as suggested by Greg KH. > v3: Resubmitted with descriptiuon text moved into the comment area. > > .../interface/vchiq_arm/vchiq_connected.c | 32 +++++++++---------- > 1 file changed, 16 insertions(+), 16 deletions(-) > > diff --git > a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c > b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c > index 1640906e3929..993535bbc479 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c > @@ -15,10 +15,10 @@ static int g_once_init; > static struct mutex g_connected_mutex; > > /**************************************************************************** > -* > -* Function to initialize our lock. > -* > -***************************************************************************/ > + * > + * Function to initialize our lock. > + * > + ***************************************************************************/ > > static void connected_init(void)
Shouldn't that really be written as: /* Function to initialize our lock */ static void connect_init(void); No need for the /****** mess, and no need for the blank line. Simple and clean is best. thanks, greg k-h _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
