On Sun, Jul 12, 2020 at 12:36:28PM +0530, Saurav Girepunje wrote: > Remove below warning in das1800.c > WARNING: possible condition with no effect (if == else) > > Signed-off-by: Saurav Girepunje <saurav.girepu...@gmail.com> > --- > drivers/staging/comedi/drivers/das1800.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/das1800.c > b/drivers/staging/comedi/drivers/das1800.c > index f16aa7e9f4f3..7ab72e83d3d0 100644 > --- a/drivers/staging/comedi/drivers/das1800.c > +++ b/drivers/staging/comedi/drivers/das1800.c > @@ -1299,12 +1299,6 @@ static int das1800_attach(struct comedi_device *dev, > outb(DAC(i), dev->iobase + DAS1800_SELECT); > outw(0, dev->iobase + DAS1800_DAC); > } > - } else if (board->id == DAS1800_ID_AO) { > - /* > - * 'ao' boards have waveform analog outputs that are not > - * currently supported. > - */ > - s->type = COMEDI_SUBD_UNUSED;
What gave that warning? The comment should show you why this is good to keep as-is, right? thanks, greg k-h _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel