Em Sun, 26 Jul 2020 14:35:12 +0530
Rohit K Bharadwaj <bharadwaj.roh...@gmail.com> escreveu:
> this patch fixes style of open brace after functions and if statements
>
> Signed-off-by: Rohit K Bharadwaj <bharadwaj.roh...@gmail.com>
> @@ -119,8 +121,9 @@ sh_css_load_blob_info(const char *fw, const struct
> ia_css_fw_info *bi,
> blob = (const unsigned char *)fw + bi->blob.offset;
>
> /* sanity check */
> - if (bi->blob.size != bi->blob.text_size + bi->blob.icache_size +
> bi->blob.data_size + bi->blob.padding_size)
> - {
> + if (bi->blob.size !=
> + bi->blob.text_size + bi->blob.icache_size +
> + bi->blob.data_size + bi->blob.padding_size) {
Please adjust the alignments here. I'm pretty sure checkpatch --strict
will end complaining with the above, as the first line ends with "=".
I would, instead, code it as:
if (bi->blob.size != bi->blob.text_size + bi->blob.icache_size +
bi->blob.data_size + bi->blob.padding_size) {
Thanks,
Mauro
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
