On 26/07/20 11:33 pm, Larry Finger wrote:
On 7/26/20 3:40 AM, Aditya Jain wrote:
On Sun, Jul 26, 2020 at 1:56 PM Greg KH <gre...@linuxfoundation.org>
wrote:
On Sun, Jul 26, 2020 at 01:32:15PM +0530, Aditya Jain wrote:
Fixing ERROR: "foo * bar" should be "foo *bar" in hal_phy_cfg.h
as reported by checkpatch.pl
Signed-off-by: Aditya Jain <aditya.jainadityajain.j...@gmail.com>
---
.../staging/rtl8723bs/include/hal_phy_cfg.h | 18
+++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/hal_phy_cfg.h
b/drivers/staging/rtl8723bs/include/hal_phy_cfg.h
index 419ddb0733aa..fd5f377bad4f 100644
--- a/drivers/staging/rtl8723bs/include/hal_phy_cfg.h
+++ b/drivers/staging/rtl8723bs/include/hal_phy_cfg.h
@@ -42,7 +42,7 @@ u32 Data
u32
PHY_QueryRFReg_8723B(
-struct adapter * Adapter,
+struct adapter *Adapter,
u8 eRFPath,
u32 RegAddr,
u32 BitMask
Ick, these are all horrid. How about just making these all on a single
line like most functions have them instead of this one cleanup?
Same for the other changes you made in this file.
thanks,
greg k-h
Agreed. I'll clean it up.
While you are at it, drop the "include;" from the subject. For
staging, the usual subject is of the form "staging: driver: thing
being done". In your case "staging: rtl8723bs: Fix coding style
errors". The directory of the files are not relevant.
Ok, I'll take care of this and update the subject in the next version of
the Patch series.
I am also not in favor of the large white space between the variable
type and the name, but that is probably the subject of separate patches.
I think, the v3 patch series resolves this.
Larry
Regards,
Aditya Jain
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
