The proposal to merge lp:~fallenpegasus/drizzle/newplugins into lp:drizzle has
been updated.
Status: Needs review => Rejected
Whiteboard changed to:
Hey Mark,
Coupla things...
New strings outputted need to be marked for gettext:
For instance:
sql_print_error("Errmsg plugin '%s' init function returned error.",
plugin->name.str);
should be:
sql_print_error(_("Errmsg plugin '%s' init function returned error."),
plugin->name.str);
Also, it's your call, but I think it will make translations easier if you made
the text "Error message plugin" rather than "Errmsg plugin". (ditto "configvar")
And, on some platforms, va_list is not directly assignable. So this:
params.ap= ap;
should be
va_copy(params.ap, ap);
What is this? :
plugin/errmsg_stderr/configure.in
If you need to inject autoconf stuff, you can use DRIZZLE_PLUGIN_ACTIONS in the
plug.in file.
And finally, at the very least all .cc and .h files need to have copyright
headers attached. A copy of the most recent template we are using can be found
in drizzled/func/log.cc.
--
https://code.edge.launchpad.net/~fallenpegasus/drizzle/newplugins/+merge/1338
You are subscribed to branch lp:drizzle.
_______________________________________________
Mailing list: https://launchpad.net/~drizzle-discuss
Post to : drizzle-discuss@lists.launchpad.net
Unsubscribe : https://launchpad.net/~drizzle-discuss
More help : https://help.launchpad.net/ListHelp
