On 05/30/2010 05:46 PM, Stewart Smith wrote: > On Fri, 28 May 2010 01:08:27 +1000, Stewart Smith <[email protected]> > wrote: >> I think unit tests for drizzled/atomics.h would be great. >> >> namely because I just found a bug in them on some of our build hosts >> (fetch_and_increment() doesn't work). >> >> It should also be fairly easy to write real unit tests for these as they >> don't poke everywhere in the server. > > I have one that I'll be pushing up fairly shortly, but it only directly > tests the pthreads implementation. A good next step would be to take it > and make sure it also tests the native implementation (gcc/sunstudio) > appropriately when we build with it. >
That should be easy - just take the test you've done and remove the pthread defines, so that we just get whatever backend is being built on that platform. Good job with tracking down that bug, btw. _______________________________________________ Mailing list: https://launchpad.net/~drizzle-discuss Post to : [email protected] Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
