Hi Travis, On Thu, Oct 21, 2010 at 8:30 AM, Travis Davies <[email protected]> wrote: > > Hi Guys, > > I am working on Bug 621870 and hoped you might give me some advice about the > best way to do this. > I am thinking of converting the 'st_sql_list' structure (in > drizzled/sql_list.h) to c++ class using the STL list data structure as > a private member. > Like: > > #include <list> > typedef class SQL_LIST > { > list<char> sql_list; > public: > void push_front(...); > void push_back(...); > ... > }; > > Is this the approach you would take?
Thanks for taking this on! Why choose this approach? Can we not just get rid of SQL_LIST altogether and simply use std::list in its place? And I'm fairly certain that list<char> isn't going to be the right type. I believe the idea was that this data structure could be used to have a list of elements of any type. Take a look at its use in drizzled/sql_lex.cc (add_to_list() function) for an example. -Dave _______________________________________________ Mailing list: https://launchpad.net/~drizzle-discuss Post to : [email protected] Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
