Hi! On Jan 1, 2012, at 3:05 PM, Henrik Ingo wrote:
> Brian, bzr tells me this code is from you: > http://bazaar.launchpad.net/~drizzle-trunk/drizzle/development/revision/2399 Its from Stewart, which is from Memcached I believe :) > Why do you leave the parent process to wait for the child to > terminate? Now when I do It should only wait to see if the parent process immediately terminates. I.E. the parent doesn't check plugin startup, but the child does. Now if the parent is sticking around after the child has gone into listen, then we definitely have a bug. Cheers, -Brian > > /usr/sbin/drizzled --daemon > > ...it means I'm left hanging in the terminal. This also means our rpm > (and probably deb) init script seems to hang too: > > # /etc/init.d/drizzled start > Starting Drizzle: > > ...since the main process never returns. > > Granted, I don't really know much about this stuff, but in all > examples I looked at the parent simply returns immediately after > successful fork (including memcached, it seems), which is the point of > daemonizing. > > I volunteer to remove above code if you ok it / if there is no good > reason it is there. > > In other news, it seems we don't test for --daemon to work > consistently :-) (cc Crews) > > henrik > PS: It's also weird to return true on failure and false on success, > even if the calling code uses those correctly (ie freak out on > true...). If I fix the above, do you mind if I swap true/false the > other way around, and then add a "!" (not) to the calling code? > > -- > [email protected] > +358-40-8211286 skype: henrik.ingo irc: hingo > www.openlife.cc > > My LinkedIn profile: http://www.linkedin.com/profile/view?id=9522559
signature.asc
Description: Message signed with OpenPGP using GPGMail
_______________________________________________ Mailing list: https://launchpad.net/~drizzle-discuss Post to : [email protected] Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
