Ok, I felt I was rambling too much, so here is the same in code form: https://code.launchpad.net/~hingo/libdrizzle/libdrizzle-versioning/+merge/92814
In addition to the below rant, I ended up bumping the so version to 4.0.0 to achieve the source tarball version number and so library version to be the same, anything else was very confusing even to me. Technically I believe there is nothing forcing us away from 2.0.1 except to avoid confusion => libdirzzle.so.2.0.1 is not the code in libdrizzle-2.0 and not what was recently distributed as libdrizzle2. Now everything would be 4: name = libdrizzle4, tar ball version = 4.0.0 and so version = 4.0.0. There is a companion branch that bumps the so version to 4.0.0 on the lp:drizzle side: lp:~hingo/drizzle/drizzle-libdrizzle-version-sync If both are merged, I believed the intended idea to only do changes in lp:drizzle and shovel them into lp:libdrizzle will work just fine going forward. I also had a look whether it makes a difference to make install from lp:drizzle vs lp:libdrizzle. The good news is that it doesn't! There are basically two directories that have the package name in them: include/libdrizzle4 share/libdrizzle4 ...these are then include/drizzle and share/drizzle on the lp:drizzle side. But the good news is that they are empty! Hence, the installation is basically identical from both. This seems like a good thing to me. (The headers are instead in include/libdrizzle-1.0 and share is just empty afaics.) [ ] Yeah, it compiles, ship it. [ ] Henrik, you don't know what you're doing here. henrik On Sun, Feb 12, 2012 at 11:16 PM, Henrik Ingo <[email protected]> wrote: > Sun, Feb 12, 2012 at 9:34 PM, Henrik Ingo <[email protected]> wrote: >> There's one more thing though. For the libdrizzle version numbers, it >> would now be natural to use the version number from configure.ac. >> However, for the variant known as libdrizzle-1.0, this is currently >> 2.x.x! >> >> condigure.ac: >> OLDLIBDRIZZLE_LIBRARY_VERSION=2:0:1 >> > > > Hmm... > > I just did a make install of lp:libdrizzle and I end up with version > 3.0.0 for the so: > > $ ls lib > libdrizzle.a libdrizzle.la libdrizzle.so libdrizzle.so.3 > libdrizzle.so.3.0.0 pkgconfig > > > Sure enough, the configure.ac is different: > > LIBDRIZZLE_LIBRARY_VERSION=3:0:0 > > On the other hand, the version given in AC_INIT is still 1.0.1, which > is used in the tar ball created by make dist: > > AC_INIT([libdrizzle],[1.0.1],[http://launchpad.net/libdrizzle]) > -> libdrizzle-1.0.1.tar.gz > > > **** > > I have following questions/suggestions: > > In lp:libdrizzle > > 1) LIBDRIZZLE_LIBRARY_VERSION=3:0:0 has been used for the code in > libdrizzle-2.0/. What you have in lp:libdrizzle should use > OLDLIBDRIZZLE_LIBRARY_VERSION=2:0:1 > > If you need to bump the version number (and I agree you might have to, > but not necessarily) then you need to go with 4:0:0. This was also the > advice of mtaylor on IRC yesterday. Even then it would imho be clearer > to continue using OLDLIBDRIZZLE_LIBRARY_VERSION as the variable name, > so it is clear which one was carried over to lp:libdrizzle. > > 2) The version in AC_INIT should be set to the same as > OLDLIBDRIZZLE_LIBRARY_VERSION Let's call it N:0:0 as an example, so > AC_INIT([libdrizzle],[N.0.0], ...). Doesn't this make sense? > > 3) make dist should produce a tar ball with the same version number > (libdrizzle-N.0.0.tar.gz) > > 4) rpm and deb packages should also use the same version number > > > In lp:drizzle > > 1) OLDLIBDRIZZLE_LIBRARY_VERSION should be set to same value as is > used in lp:libdrizzle. When merging from one to another, it should > automatically also change the value. > > 2) AC_INIT has it's own life (7.1). > > 3) make dist does nothing special. (Version comes from drizzle server) > > 4) rpm and deb packages do not output a libdrizzle package at all. > > 5) make install should produce so libraries with the same version as > lp:libdrizzle would (libdrizzle.so.N.0.0). > > > > In any case, the current situation is blocking any packaging efforts. > Please comment. > > henrik > -- > [email protected] > +358-40-8211286 skype: henrik.ingo irc: hingo > www.openlife.cc > > My LinkedIn profile: http://www.linkedin.com/profile/view?id=9522559 -- [email protected] +358-40-8211286 skype: henrik.ingo irc: hingo www.openlife.cc My LinkedIn profile: http://www.linkedin.com/profile/view?id=9522559 _______________________________________________ Mailing list: https://launchpad.net/~drizzle-discuss Post to : [email protected] Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
