Hi moriginal / Zisis Now that I have time to look at the code a little... you should do such check in the init() function just at the end of auth_ldap.cc.
Like you say, if connection to LDAP server can't be established, then drizzled startup will fail with an error message. You could do the same: after the variables are registered, you can check for the value of the scope variable and if it is not correct, print an error message and return a non-zero value. henrik On Tue, Mar 20, 2012 at 7:10 PM, Zisis Sialveras <[email protected]> wrote: > Hello folks, i am new to drizzle and i am playing around with > low-hanging-fruits. > I am currently trying to code this requested feature: > https://bugs.launchpad.net/drizzle/+bug/932837. > > To implement this, i added a new variable (scope) to read from the terminal > the user scope of search (base/one/sub/children) > > The only thing that left is the error checking of variable. I mean, if the > user gives from terminal ..--auth-ldap.scope=foo, and foo it not one of the > base/one/sub/child, drizzled should be exiting with an error. My problem is > *where* should i check if the scope variable is correct. One idea that i > have thought is, to check this inside AuthLDAP::connect(). > > Is this one correct ? I mean, it was maybe even better to check the scope > variable before AuthLDAP::connect. > > What's your opinions ? > > Thank you for your time. > Zisis > > _______________________________________________ > Mailing list: https://launchpad.net/~drizzle-discuss > Post to : [email protected] > Unsubscribe : https://launchpad.net/~drizzle-discuss > More help : https://help.launchpad.net/ListHelp -- [email protected] +358-40-8211286 skype: henrik.ingo irc: hingo www.openlife.cc My LinkedIn profile: http://www.linkedin.com/profile/view?id=9522559 _______________________________________________ Mailing list: https://launchpad.net/~drizzle-discuss Post to : [email protected] Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
