On Fri, Jun 15, 2012 at 2:01 PM, Mohit Srivastava <srivastavamohi...@gmail.com> wrote: > DBAccess.h > > DBAccess(Json::Value &json_in,Json::Value &json_out); > void execute(const char* type,const char* schema,const char* table); > I think json_in, schema and table belong together. I would change the > above like this: > > DBAccess(enum evhttp_cmd_type type,const char* schema,const char* > table,Json::Value &json_in,Json::Value &json_out); > void execute(); > > I think , If we put schema , table as constructor argument , then we have to > specify them as member of class. And that is not needed , they are used only > as temporary purpose.
Well, DBAccess only has one method, so the same is true for json_in and json_out too :-) My opinion is just they should all be in the same place, and I would pass them in the constructor arguments list and make all of them member variables. henrik -- henrik.i...@avoinelama.fi +358-40-8211286 skype: henrik.ingo irc: hingo www.openlife.cc My LinkedIn profile: http://www.linkedin.com/profile/view?id=9522559 _______________________________________________ Mailing list: https://launchpad.net/~drizzle-discuss Post to : drizzle-discuss@lists.launchpad.net Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
