Author: tobr
Date: Wed Jun 13 10:23:00 2012
New Revision: 1349729
URL: http://svn.apache.org/viewvc?rev=1349729&view=rev
Log:
fixed potential issues reported by the pmd site report
Modified:
incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/api/Protocol.java
incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/impl/MultiThreadedTaskMaster.java
incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/parse/html/HtmlParser.java
incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/protocol/http/ContentTooLongException.java
incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/validator/ChainTaskValidator.java
Modified:
incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/api/Protocol.java
URL:
http://svn.apache.org/viewvc/incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/api/Protocol.java?rev=1349729&r1=1349728&r2=1349729&view=diff
==============================================================================
---
incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/api/Protocol.java
(original)
+++
incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/api/Protocol.java
Wed Jun 13 10:23:00 2012
@@ -17,7 +17,6 @@
package org.apache.droids.api;
import java.io.IOException;
-import java.net.MalformedURLException;
import java.net.URI;
/**
Modified:
incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/impl/MultiThreadedTaskMaster.java
URL:
http://svn.apache.org/viewvc/incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/impl/MultiThreadedTaskMaster.java?rev=1349729&r1=1349728&r2=1349729&view=diff
==============================================================================
---
incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/impl/MultiThreadedTaskMaster.java
(original)
+++
incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/impl/MultiThreadedTaskMaster.java
Wed Jun 13 10:23:00 2012
@@ -22,7 +22,6 @@ import java.util.concurrent.LinkedBlocki
import java.util.concurrent.ThreadPoolExecutor;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicLong;
-import org.apache.droids.AbstractDroid;
import org.apache.droids.api.DelayTimer;
import org.apache.droids.api.Droid;
import org.apache.droids.api.Task;
@@ -40,7 +39,7 @@ import org.slf4j.LoggerFactory;
public class MultiThreadedTaskMaster<T extends Task> implements TaskMaster<T>
{
- protected static final Logger LOG =
LoggerFactory.getLogger(AbstractDroid.class);
+ protected static final Logger LOG =
LoggerFactory.getLogger(MultiThreadedTaskMaster.class);
private static final long TICKLE_TIME = 1000L;
/**
@@ -326,7 +325,7 @@ public class MultiThreadedTaskMaster<T e
}
@SuppressWarnings("unused")
- public Worker getWorker()
+ public Worker<? extends Task> getWorker()
{
return worker;
}
Modified:
incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/parse/html/HtmlParser.java
URL:
http://svn.apache.org/viewvc/incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/parse/html/HtmlParser.java?rev=1349729&r1=1349728&r2=1349729&view=diff
==============================================================================
---
incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/parse/html/HtmlParser.java
(original)
+++
incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/parse/html/HtmlParser.java
Wed Jun 13 10:23:00 2012
@@ -34,8 +34,6 @@ import org.apache.droids.parse.ParseImpl
import org.apache.xerces.xni.parser.XMLDocumentFilter;
import org.cyberneko.html.filters.ElementRemover;
import org.cyberneko.html.parsers.SAXParser;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
import org.xml.sax.InputSource;
import org.xml.sax.SAXException;
import org.xml.sax.SAXNotRecognizedException;
@@ -50,8 +48,6 @@ import org.xml.sax.SAXNotSupportedExcept
@Deprecated
public class HtmlParser implements Parser {
- private static final Logger LOG = LoggerFactory.getLogger(HtmlParser.class);
-
private Map<String, String> elements= null;
public Map<String, String> getElements() {
Modified:
incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/protocol/http/ContentTooLongException.java
URL:
http://svn.apache.org/viewvc/incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/protocol/http/ContentTooLongException.java?rev=1349729&r1=1349728&r2=1349729&view=diff
==============================================================================
---
incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/protocol/http/ContentTooLongException.java
(original)
+++
incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/protocol/http/ContentTooLongException.java
Wed Jun 13 10:23:00 2012
@@ -25,7 +25,7 @@ public class ContentTooLongException ext
public ContentTooLongException(String message)
{
- super();
+ super(message);
}
}
Modified:
incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/validator/ChainTaskValidator.java
URL:
http://svn.apache.org/viewvc/incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/validator/ChainTaskValidator.java?rev=1349729&r1=1349728&r2=1349729&view=diff
==============================================================================
---
incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/validator/ChainTaskValidator.java
(original)
+++
incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/validator/ChainTaskValidator.java
Wed Jun 13 10:23:00 2012
@@ -36,7 +36,7 @@ public final class ChainTaskValidator<T
}
@Override
- public final boolean validate(final T task) {
+ public boolean validate(final T task) {
for (final TaskValidator<T> taskValidator : this.validatorChain) {
if (!taskValidator.validate(task)) {
return false;
@@ -45,7 +45,7 @@ public final class ChainTaskValidator<T
return true;
}
- public final void addTaskValidator(final TaskValidator<T> taskValidator) {
+ public void addTaskValidator(final TaskValidator<T> taskValidator) {
this.validatorChain.add(taskValidator);
}
