On Tue, 2008-11-04 at 11:44 +0100, Oleg Kalnichevski wrote: > On Mon, 2008-11-03 at 16:33 -0600, Ross Gardler wrote: > > On 3 Nov 2008, at 10:38, Oleg Kalnichevski wrote: > > > > > On Mon, 2008-11-03 at 07:40 -0600, Ross Gardler wrote: > > >> On 3 Nov 2008, at 06:03, Oleg Kalnichevski wrote: > > >> > > >>> There are two things in Droids that irk me a little > > >>> > > >>> (1) There are lots of places where output is printed to stdout > > >>> bypassing > > >>> the logging framework. I personally think this is suboptimal. > > >> > > >> I doubt anyone here would disagree, so a patch would be readily > > >> accepted. > > >> > > > > > > Are we 'commit then review' or 'review than commit'? > > > > If your a committer then I guess it's CTR - sorry I didn't realise you > > were a committer. > > > > Ross > > No harm done. I am going to fix console output and commit changes to SVN > (CTR mode) and to prepare a patch with exception handling changes for > review (RTC mode).
Hi Oleg, please go ahead and submit both since I guess we all agree on your valid points. Droids still has parts of prototype code in it (hacked to have a proof of concept) so good as gold if you can reduce this bad code. TIA. salu2 -- Thorsten Scherler thorsten.at.apache.org Open Source Java consulting, training and solutions
