[
https://issues.apache.org/jira/browse/DROIDS-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701596#action_12701596
]
Ryan McKinley commented on DROIDS-46:
-------------------------------------
This implementation looks good -- I think it should replace the existing
MultiThreadedTaskMaster.
The remaining issues seem to be:
* wire in the TaskExceptionHandler
* PausableTaskMaster?
* terminate cleanup -- "//TODO it isn't a very good idea to check the
activeCount"
When I added the PausableTaskMaster, i wanted a way to pause operations and
continue. Since the 'pause' does not actually pause the workers, and the
application state is held in the TaskQueue, i'm not sure how valuable it is.
shutting down and restarting would have the same affect as a pause.
I think we can safely remove the PausableTaskMaster interface.
---------
Any thoughts on hanging on to TaskMaster hanging on to all running FutureTasks?
This could potentially give us the interrogate currently running tasks and
perhaps kill them Future#cancel(boolean mayInterruptIfRunning)
> MultiThreadedTaskMaster (WorkRunner) memory leak
> ------------------------------------------------
>
> Key: DROIDS-46
> URL: https://issues.apache.org/jira/browse/DROIDS-46
> Project: Droids
> Issue Type: Bug
> Components: core
> Affects Versions: 0.01
> Reporter: Mingfai Ma
> Priority: Blocker
> Attachments: DROIDS-46-SimpleTaskMaster-GC.png, SimpleTaskMaster.java
>
>
> In a Droids job that has been run for around 6 hours, it eats a lot of memory
> that cannot be free by the GC. with "jmap -histo", the report shows there are
> 1.5m instance of MultiThreadedTaskMaster$WorkerRunner and
> LinkedBlockingQueue$Node that consumes 594+475m memory. The instance cannot
> be free by any full GC (and they reside in tenured generation of the heap)
> num #instances #bytes class name
> ----------------------------------------------
> 1: 957740 1007648216 [C
> 2: 14874175 594967000
> org.apache.droids.impl.MultiThreadedTaskMaster$WorkerRunner
> 3: 14873977 475967264
> java.util.concurrent.LinkedBlockingQueue$Node
> For #1, I'm not use what's that but that may be a problem with my own
> program. But #2 and #3 shall come from Droids. I haven't checked the source
> of MultiThreadedTaskMaster yet and it would be great if the original
> developer could take a quick look to see if there are any chance that the
> WorkRunner may be referenced.
> Besides, there is another issue related to MultiThreadedTaskMaster DROIDS-43
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
