[ 
https://issues.apache.org/jira/browse/DROIDS-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974915#action_12974915
 ] 

Otis Gospodnetic edited comment on DROIDS-111 at 12/24/10 9:13 AM:
-------------------------------------------------------------------

Tabs should be spaces.  Maybe a unit test would be good to add.
Patch applies cleanly, existing unit tests still pass, committed - thanks!

Now could somebody with JIRA privileges mark this issue as Fixed, please?


      was (Author: otis):
    Tabs should be spaces.  Maybe a unit test would be good to add.
Patch applies cleanly, existing unit tests still pass, committed - thanks!

  
> Open the API of RegexURLFilter to other types of input
> ------------------------------------------------------
>
>                 Key: DROIDS-111
>                 URL: https://issues.apache.org/jira/browse/DROIDS-111
>             Project: Droids
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.0.1
>            Reporter: Eugen Paraschiv
>             Fix For: 0.0.1
>
>         Attachments: DROIDS-111_v1.patch
>
>
> The only type of input RegexURLFilter accepts is the name of a file 
> (setFile), which is very restrictive. 
> I'm suggesting to introduce another input type in the API - the regex 
> expression, which makes much more sense than just being able to specify the 
> regex expressions in an external file. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to