[ 
https://issues.apache.org/jira/browse/DROIDS-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995034#comment-12995034
 ] 

Eugen Paraschiv commented on DROIDS-120:
----------------------------------------

Thank you for the quick feedback, and for making me aware of the direction the 
Droids queue implementation is evolving towards. Here's my 2 cents on the issue 
- DROIDS-56 is a major restructuring of the codebase, and it already has a 
lifespan of several months. It is clearly a good direction but it also may or 
may not make it into 0.0.1. 
This issue is a minor but beneficial change on the current codebase, dealing 
with a single method in a single class but improving the overall experience. So 
my view is that the two issues do not exclude each other - if the patch for 
this issue is OK, then it will improve the codebase now, and when DROIDS-56 is 
going to be committed, then this merge collection will simply be addAll on the 
queue which will also address the problem. 
Hope this makes sense. 
Thanks again. 
Eugen. 

> Better exception handling in SimpleTaskQueue - merge
> ----------------------------------------------------
>
>                 Key: DROIDS-120
>                 URL: https://issues.apache.org/jira/browse/DROIDS-120
>             Project: Droids
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.0.1
>            Reporter: Eugen Paraschiv
>             Fix For: 0.0.1
>
>         Attachments: DROIDS-120_v1.patch
>
>
> In SimpleTaskQueue - merge, any exception in any of the individual tasks 
> would end up in closing down the entire process and loosing all the results 
> in that particular collection. 
> This should not be the case - when iterating over a (possibly large) 
> collection, where each result is relevant, an exception should be logged and 
> the iteration should continue on to the next element. 

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to