[ 
https://issues.apache.org/jira/browse/DROIDS-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000152#comment-13000152
 ] 

Bertil Chapuis commented on DROIDS-119:
---------------------------------------

Thanks you very much for the patch. I Just have two comments before someone 
apply it. The unit tests in droids-spring were failing after I applied the 
patch. The new interface and class does not contains the ASF license headers. 

I personally think these utility classes which belongs to specific use cases 
should be moved to the newly created droids-example project or in a future 
droids-utils project. Furthermore we should think about improving the test 
coverage of such additions.

> Allow SaveHandler to decide the location (directory) where it saves the 
> content
> -------------------------------------------------------------------------------
>
>                 Key: DROIDS-119
>                 URL: https://issues.apache.org/jira/browse/DROIDS-119
>             Project: Droids
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.0.2
>            Reporter: Eugen Paraschiv
>             Fix For: 0.0.2
>
>         Attachments: droids119.patch
>
>
> At this point, SaveHandler doesn't provide a way to configure where the 
> content is saved, other than a single directory path, which clearly lacks 
> flexibility. 
> A common scenario is to crawl a site and configure where the content gets 
> saved based on some particular logic, as opposed to having all content (which 
> may be a lot) saved in one single directory. 
> For example, I may want to save 
> www.domain.com/category1/... into directory a category1 directory and 
> www.domain.com/category2/... into directory a category2 directory. 

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to