[
https://issues.apache.org/jira/browse/DROIDS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008411#comment-13008411
]
Thorsten Scherler commented on DROIDS-123:
------------------------------------------
The problem to change the formating now is that most of the patches that are
still open will fail to apply. IMO it would make sense to run the formating
tool once we create the trunk again and use a default settings.xml for eclipse
for the formating.
> Better formatting consistency for the Droids codebase
> ------------------------------------------------------
>
> Key: DROIDS-123
> URL: https://issues.apache.org/jira/browse/DROIDS-123
> Project: Droids
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.0.2
> Reporter: Eugen Paraschiv
> Fix For: 0.0.2
>
> Attachments: DROIDS-123-introducing-jalopy.patch,
> DROIDS-123_step1_v1.patch, DROIDS-123_step2_v1.patch, eclipse-java-profile.xml
>
>
> The formatting in droids should effectively be the same as the standard Java
> Conventions build in Eclipse formatter. However, the are multiple formatting
> inconsistencies in the droids codebas.
> Examples:
> 1. braces
> - SimpleTaskQueue - even in the same class, there are cases where the opening
> braces are on the same line as the method signature:
> public T next() {
> and cases where they are not:
> public void clear()
> {
> 2. whitespace
> - sometimes there is a whitespace between a 'for' and the '('
> for (
> and sometimes there is not:
> for(
> The proposal to deal with this is to start with the Java build in formatter
> in Eclipse (with a few minor changes), and format the entire droids codebase
> - the changes should be minor in most cases.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
