CompleteStep in submission LOSES SUBMISSION if an exception is thrown
---------------------------------------------------------------------
Key: DS-255
URL: http://jira.dspace.org/jira/browse/DS-255
Project: DSpace 1.x
Issue Type: Bug
Components: DSpace API
Affects Versions: 1.5.2, 1.6.0
Environment: MacOS/Sun Java 1.5/oracle/XMLUI
Reporter: Larry Stone
Priority: Minor
Attachments: CompleteStep.diff.txt
When completing a submission that is installed directly in the archive (passing
through all workflow), the Item can be lost (although the Item table row is
left disconnected from workspace, workflow, or collections) if an exception
gets thrown in that last step. The problem is that the context gets committed
upstream, in the XMLUI continuation code that does not check for errors and
appears to lose track of exceptions.
The proposed patch catches exceptions in CompleteStep, where there is a call to
Context,commit() in the case that all goes well. It rolls back the transaction
in case of an exception, so the data model is NOT left in an inconsistent
state. I think it is reasonable to make this step code take control the
transaction in the case of failures since it was already doing so in the case
of success.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.dspace.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
