[ 
http://jira.dspace.org/jira/browse/DS-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=10518#action_10518
 ] 

Stuart Lewis commented on DS-44:
--------------------------------

Patch from SF:

Index: dspace-api/src/main/java/org/dspace/app/statistics/LogAnalyser.java
===================================================================
--- dspace-api/src/main/java/org/dspace/app/statistics/LogAnalyser.java 
(revision 3638)
+++ dspace-api/src/main/java/org/dspace/app/statistics/LogAnalyser.java Fri Mar 
27 14:46:56 NZDT 2009
@@ -423,12 +423,12 @@
                     {
                         // first find out if we are constraining by date and 
                         // if so apply the restrictions
-                        if (logLine.beforeDate(startDate))
+                        if (!logLine.afterDate(startDate))
                         {
                             continue;
                         }
                         
-                        if (logLine.afterDate(endDate))
+                        if (!logLine.beforeDate(endDate))
                         {
                             break;
                         }


> Monthly statistics skip first and last of month - ID: 2541435
> -------------------------------------------------------------
>
>                 Key: DS-44
>                 URL: http://jira.dspace.org/jira/browse/DS-44
>             Project: DSpace 1.x
>          Issue Type: Bug
>    Affects Versions: 1.5.1
>            Reporter: Charles Kiplagat
>
> Adding up the monthly view totals for a given item in
> /dspace/reports/report-year-month.html files yields less than the aggregate
> total for the item in the current report-general-year-month-day.html.
> This appears to be an issue with the logLine.beforeDate and
> logLine.afterDate functions in LogLine.java as they are used in
> LogAnalyser.java
> They return true when the dates are equal. Which forces the function
> processLogs to skip over the log line in LogAnalyser.java for the startDate
> and endDate (first and last of month).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.dspace.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Dspace-devel mailing list
Dspace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to