[ 
http://jira.dspace.org/jira/browse/DS-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=10969#action_10969
 ] 

Andrea Bollini commented on DS-217:
-----------------------------------

sorry for the long delay...
I have rechecked the patch and all work fine except that I have just notice 
that the xmlui show the collection license text in the collection home page...
when the license text is customized including substitution variable the 
collection home show this as "raw text"... the jspui interface doesn't show the 
license text at all.
I see two possible solutions to this:
1) I can show in the xmlui a license text using some mock variable for the 
substitution
2) I can remove the license text in the collection home as in the jspui I'm not 
sure about how many work is required to apply the first solution so I can't be 
sure to be able to complete it just in time for inclusion in the 1.6 release

Anyway, I suggest to apply the second solution mainly because the license text 
is intended as an agreement between the submitter and the repository and not an 
agreement between the repository and the reader.

> Hardcoded String in the license bitstream
> -----------------------------------------
>
>                 Key: DS-217
>                 URL: http://jira.dspace.org/jira/browse/DS-217
>             Project: DSpace 1.x
>          Issue Type: Bug
>          Components: DSpace API
>    Affects Versions: 1.5.0, 1.5.1, 1.5.2
>            Reporter: Andrea Bollini
>            Assignee: Andrea Bollini
>            Priority: Critical
>             Fix For: 1.6.0
>
>         Attachments: DS-217-substitution-variable-license.patch
>
>
> The Item's licenseGranted method hardcoded the string:
> "License granted by " + eperson.getFullName() + " (" + eperson.getEmail() + 
> ") on "+ DCDate.getCurrent().toString() + " (GMT):\n\n"
> at the start of the license bitstream. This is not desiderable for some user 
> that like to have this text translated and/or in a different position.
> Moreover, could be appropriate move this method in the LicenseStep processing 
> class? should we allow the license text itself to contain parameter that will 
> be replaced at runtime with current user data and date so that the license 
> showed to the user will be exactly the same that will be stored?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.dspace.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to