[ 
https://jira.duraspace.org/browse/DS-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17998#action_17998
 ] 

Richard Rodgers commented on DS-742:
------------------------------------

Not sure where/ when the NPE occurs, but changeset 5739 (the fix) contains an 
error that breaks the build.
The getMetadata() method that returns 'terms' is never null, but it *can* be a 
zero-length array. In this case, the test
terms[0] != null will throw a ArrayIndexOutOfBounds exception.
Checking in a fix - although reverting would work also. Need more detail in 
this ticket to address the underlying issue.


> Embargo Fails with Null Pointer Exception on Item Install.
> ----------------------------------------------------------
>
>                 Key: DS-742
>                 URL: https://jira.duraspace.org/browse/DS-742
>             Project: DSpace
>          Issue Type: Bug
>          Components: DSpace API
>    Affects Versions: 1.6.0, 1.6.1, 1.6.2, 1.7.0
>            Reporter: Mark Diggory
>             Fix For: 1.7.0
>
>
> Embargo fails because the code fails to check for NullPointers appropriately.
> Fix
>         
>         DCDate result = null;
>         
>         // Its very poor form to blindly use an object that could be null...
>         if(terms != null && terms[0] != null)
>         {
>               result = setter.parseTerms(context, item, terms.length > 0 ? 
> terms[0].value : null);
>         }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://jira.duraspace.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
The Next 800 Companies to Lead America's Growth: New Video Whitepaper
David G. Thomson, author of the best-selling book "Blueprint to a 
Billion" shares his insights and actions to help propel your 
business during the next growth cycle. Listen Now!
http://p.sf.net/sfu/SAP-dev2dev
_______________________________________________
Dspace-devel mailing list
Dspace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to