[
https://jira.duraspace.org/browse/DS-748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18421#action_18421
]
Kim Shepherd commented on DS-748:
---------------------------------
Committed the following changes:
* Applied Bill's patch to DIM-Handler, fixing the span tag closure problem
* Changed the renderCOinS template to a modified version of the pre-SFX
template (unlike COinS.xsl, this template will attempt to grab all DC metadata
apart from description/provenance))
* Inserted a commented-out SFX version of the renderCOinS template to assist
SFX users, who we're now breaking COinS for
I know we're close to final 1.7, but any quick last minute testing would be
really appreciated.
As mentioned in other comments, COinS has always been 'broken' in terms of
actual DC metadata population, but I've had a go at getting something in with
the DIM-Handler.xsl patch. It just chops off the qualifiers, converts
contributor.author to creator, and populates.
I haven't touched the version that dri2xhtml-alt/Mirage uses, so comparison
should be pretty easy.
My main concern is that we end up exposing metadata that people don't want
seen, but on the other hand, at least we're no longer exposing internal
metadata schemas (ie. everything that matched @mdschema != 'dc') which are even
more likely to have private metadata.
> COinS in XMLUI has invalid referrer Id and dc metadata; spans are not
> properly constructed
> ------------------------------------------------------------------------------------------
>
> Key: DS-748
> URL: https://jira.duraspace.org/browse/DS-748
> Project: DSpace
> Issue Type: Bug
> Components: XMLUI
> Affects Versions: 1.6.0, 1.6.1, 1.6.2
> Reporter: Bill Hays
> Assignee: Tim Donohue
> Attachments: DIM-Handler-COinS-patch-5929.diff
>
> Original Estimate: 1 hour
> Remaining Estimate: 1 hour
>
> 1. The referrerId is hard-coded as "dryad.org" and there doesn't seem to be
> a reasonably simple way to either pull a HTTP request parameter or a DSpace
> config property value and use that instead since the xsl transform at that
> point cannot reach the dri document.
> 2. The format identifier "dc" implies strict Dublin Core according to the
> OpenURL spec and the COinS online docs. Selectively using qdc seems to go
> against that. But trying to crosswalk qdc to dc also seems very difficult in
> the Manakin context.
> 3. What can be easily fixed is the wrapping of the COinS spans around item
> titles which clearly goes against basic practice as discussed in the COinS
> online docs. The problem here is that mouse rollovers inappropriately
> display popups of the context objects. It is also unclear to me whether the
> placing of multiiple COinS on result screens is sensible across different
> consuming applications for COinS. The spans should have not content except
> some whitespace to force the existence of a closing tag.
> These first two issues don't appear to be easy to fix and there is no way to
> turn off COinS without editing the DIMHandler xsl. So, by default, any given
> DSpace instance will be rendering invalid COinSs, though they may work for
> certain COinS-consuming applications. If no one can fix these issues in the
> near term, I recommend that the COinS implementation be removed from the
> trunk and a separate patch be made available with instructions for
> customizations for those wanting this feature.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.duraspace.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d
_______________________________________________
Dspace-devel mailing list
Dspace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-devel
