[ https://jira.duraspace.org/browse/DS-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20413#action_20413 ]
Robin Taylor commented on DS-852: --------------------------------- Changes committed to trunk, version 6384. Note. Any references to flag webui.submit.enable-cc can now be deleted from the code and config. I'll do this once MIT's Creative Commons work is committed. > Split the Creative Commons and Licence steps into two seperate steps. > --------------------------------------------------------------------- > > Key: DS-852 > URL: https://jira.duraspace.org/browse/DS-852 > Project: DSpace > Issue Type: Improvement > Components: XMLUI > Reporter: Robin Taylor > Assignee: Robin Taylor > Fix For: 1.8.0 > > Attachments: Add_CC_License_Step.patch, CCLicenseStep.java, > CCLicenseStep.java, item-submission.xml, JSPCCLicenseStep.java, > JSPLicenseStep.java, LicenseStep.java, LicenseStep.java > > > At the moment I'm just looking for comments as I may have misunderstood the > code, but it seems to me that.. > The Creative Commons step and the Licence step are somewhat artificially > grouped together as one step in item-submission.xml. In order for this to > work there is a test at the start of LicenseStep that checks to see if > webui.submit.enable-cc is set to true in dspace.cfg and if so then control is > effectively passed to CCLicenseStep. It would be simpler if these classes > were completely independent of each other and defined as separate steps in > item-submission.xml. It would also mean we could remove the unneccessary flag > webui.submit.enable-cc from dspace.cfg. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.duraspace.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ------------------------------------------------------------------------------ What Every C/C++ and Fortran developer Should Know! Read this article and learn how Intel has extended the reach of its next-generation tools to help Windows* and Linux* C/C++ and Fortran developers boost performance applications - including clusters. http://p.sf.net/sfu/intel-dev2devmay _______________________________________________ Dspace-devel mailing list Dspace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspace-devel