Cleanup "Failed to Unregister the MBean" error messages in logs, as they are
not always errors
----------------------------------------------------------------------------------------------
Key: DSRV-15
URL: https://jira.duraspace.org/browse/DSRV-15
Project: DSpace Services Module
Issue Type: Improvement
Components: kernel
Reporter: Tim Donohue
Priority: Major
Fix For: 2.0.4
Attachments: DSpaceKernelManager.patch
When the DSpace Kernel is shutdown (DSpaceKernelImpl.destroy()), it will
occasionally report the following to the DSpace Logs:
2011-06-15 06:36:13,681 ERROR org.dspace.kernel.DSpaceKernelManager @ WARN
Failed to unregister the MBean:
org.dspace:name=7b509d98-8e23-4a6f-b518-3141009e8529,type=DSpaceKernel
To me this error message has two main issues:
(1) I don't believe it's always in fact an error, despite the fact that it is
reported as such in the logs
(2) The message itself gives no useful information to DSpace Users (or
developers) as to why the MBean may not have been unregistered properly
This error handling in the DSpaceKernelManager should be cleaned up and
improved so that it provides more useful error/warning messages.
Here's the location of this error handling in DSpaceKernelManager:
https://fisheye3.atlassian.com/browse/dspace/modules/dspace-services/trunk/api/src/main/java/org/dspace/kernel/DSpaceKernelManager.java?hb=true#to183
I think the proper way to fix this would be to actually determine which form of
error was thrown, and handle each properly. See the proposed
DSpaceKernelManager.patch.
I'd appreciate it if someone can review these changes. If they seem reasonable,
hopefully we can release this fix as part of version 2.0.4 (in DSpace 1.8.0)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.duraspace.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security
threats, fraudulent activity, and more. Splunk takes this data and makes
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2
_______________________________________________
Dspace-devel mailing list
Dspace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-devel
