Mark, This seems reasonable to me. At a glance it looks like it really won't affect 'mvn package' (which should still auto-fill out the params in dspace.cfg for you).
Most of the long list of profiles in the [dspace-src]/dspace/pom.xml are really just to help auto-build source code for you if it exists (so, many of them don't run unless they find specific DSpace source modules). - Tim On 7/29/2011 4:04 PM, Mark H. Wood wrote: > A small patch would be really helpful in making the model DSpace > directories usable both for installation and for unit testing. I need > a way for dspace.cfg to be copied differently in those two > environments, such that in the test environment dspace.dir points at > the test environment and mail.server points at something that might > work. > > Comments? Suggestions for testing, beyond just 'mvn package' and look > at the result? (All those profiles are scaring me.) > > Index: pom.xml > =================================================================== > --- pom.xml (revision 6508) > +++ pom.xml (working copy) > @@ -30,6 +30,11 @@ > <url>http://scm.dspace.org/svn/repo/dspace/trunk/dspace</url> > </scm> > > +<properties> > +<default.dspace.dir>/dspace</default.dspace.dir> > +<default.mail.server>smtp.example.com</default.mail.server> > +</properties> > + > <profiles> > > <!-- > Index: config/dspace.cfg > =================================================================== > --- config/dspace.cfg (revision 6508) > +++ config/dspace.cfg (working copy) > @@ -22,7 +22,7 @@ > ##### Basic information ###### > > # DSpace installation directory > -dspace.dir = /dspace > +dspace.dir = ${default.dspace.dir} > > # DSpace host name - should match base URL. Do not include port > number > dspace.hostname = localhost > @@ -86,7 +86,7 @@ > ##### Email settings ###### > > # SMTP mail server > -mail.server=smtp.myu.edu > +mail.server = ${default.mail.server} > > # SMTP mail server authentication username and password (if required) > # mail.server.username = myusername > > > > > ------------------------------------------------------------------------------ > Got Input? Slashdot Needs You. > Take our quick survey online. Come on, we don't ask for help often. > Plus, you'll get a chance to win $100 to spend on ThinkGeek. > http://p.sf.net/sfu/slashdot-survey > > > > _______________________________________________ > Dspace-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/dspace-devel ------------------------------------------------------------------------------ Got Input? Slashdot Needs You. Take our quick survey online. Come on, we don't ask for help often. Plus, you'll get a chance to win $100 to spend on ThinkGeek. http://p.sf.net/sfu/slashdot-survey _______________________________________________ Dspace-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dspace-devel
